feat(gen) add Dockerfile and docker-compose.yml support #938
Conversation
|
@kennu have time to re-visit this? |
|
It would be nice if we could deploy a docker image from a development repo. For instance you could use an automated build on the docker hub and point it to your project's git repo. However we would need a more complex dockerfile like the one I posted here. The difference is that setup builds the entire project in the docker image and then sets it up for production use. Pros:
Cons:
|
kennu
force-pushed
the
canary
branch
2 times, most recently
from
1809723 to
44c946a
Compare
|
Hi guys, I rebased the changes but still need to fix something to pass the tests. |
Add support to run generated Angular-Fullstack applications as Docker containers by including Dockerfile, docker-compose.yml and .dockerignore. When the application is built with grunt build, these files are copied to the dist directory. The Docker container can then be built and started there with the "docker-compose up" command. When Mongoose is used, Docker Compose will also launch a MongoDB container, eliminating the need to install MongoDB on the local machine. Note that Docker and Docker Compose must be installed for Docker support to work. They are available on Linux, OS X and Windows.
|
Now the tests pass, but for some reason I was unable to add a new test that would specify docker: true and generate Dockerfile and other files. The generator just ignored the setting. |
| @@ -0,0 +1,4 @@ | |||
| # Production Dockerfile - Used in the dist directory after grunt build | |||
| FROM node:0.12-onbuild | |||
|
Sorry, I'm not really using Docker any more for this kind of projects so I can't put much effort into this. (The original pull request was made over a year ago.) |
|
@kennu yeah I feared that, this PR has been open for a long time. |
Add support to run generated Angular-Fullstack applications as Docker containers by including
Dockerfile, docker-compose.yml and .dockerignore. When the application is built with grunt
build, these files are copied to the dist directory. The Docker container can then be built
and started there with the "docker-compose up" command. When Mongoose is used, Docker Compose
will also launch a MongoDB container, eliminating the need to install MongoDB on the local
machine. Note that Docker and Docker Compose must be installed for Docker support to work.
They are available on Linux, OS X and Windows.